Re: should check interrupts in BuildRelationExtStatistics ? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: should check interrupts in BuildRelationExtStatistics ?
Date
Msg-id 3592964.1652067393@sss.pgh.pa.us
Whole thread Raw
In response to should check interrupts in BuildRelationExtStatistics ?  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: should check interrupts in BuildRelationExtStatistics ?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> How long can the backend remain unresponsive?  I don't think that
> anybody would object to the addition of some CHECK_FOR_INTERRUPTS() in
> areas where it would be efficient to make the shutdown quicker, but
> we need to think carefully about the places where we'd want to add
> these.

CHECK_FOR_INTERRUPTS is really quite cheap, just a test-and-branch.
I wouldn't put it in a *very* tight loop, but one test per row
processed while gathering stats is unlikely to be a problem.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: should check interrupts in BuildRelationExtStatistics ?
Next
From: Corey Huinker
Date:
Subject: Re: Query generates infinite loop