Re: Compilation issue on Solaris. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Compilation issue on Solaris.
Date
Msg-id 3579142.1657331183@sss.pgh.pa.us
Whole thread Raw
In response to Compilation issue on Solaris.  (Ibrar Ahmed <ibrar.ahmad@gmail.com>)
Responses Re: Compilation issue on Solaris.
List pgsql-hackers
Ibrar Ahmed <ibrar.ahmad@gmail.com> writes:
> While compiling the PostgreSQL I have found that *memset_s function
> requires a define "*__STDC_WANT_LIB_EXT1__*" *
> *explicit_bzero.c:* In function ‘*explicit_bzero*’:
> *explicit_bzero.c:23:9:* *warning: *implicit declaration of function ‘
> *memset_s*’; did you mean ‘*memset*’? [*-Wimplicit-function-declaration*]

Hmm.

> Attached is the patch to define that in the case of Solaris.

If you don't have any test you want to make before adding the
#define, I don't think this is idiomatic use of autoconf.
Personally I'd have just added "-D__STDC_WANT_LIB_EXT1__" into
the CPPFLAGS for Solaris, perhaps in src/template/solaris,
or maybe just adjust the stanza immediately above this one:

if test "$PORTNAME" = "solaris"; then
  CPPFLAGS="$CPPFLAGS -D_POSIX_PTHREAD_SEMANTICS"
fi

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ibrar Ahmed
Date:
Subject: Compilation issue on Solaris.
Next
From: Bruce Momjian
Date:
Subject: Re: doc: Fix description of how the default user name is chosen