Re: Fix missing semicolon in pl_gram.y for option_value rule - Mailing list pgsql-hackers

From Chao Li
Subject Re: Fix missing semicolon in pl_gram.y for option_value rule
Date
Msg-id 355AF12F-82DA-48A1-8B4A-ECC1247653C8@gmail.com
Whole thread
Responses Re: Fix missing semicolon in pl_gram.y for option_value rule
List pgsql-hackers

> On Jun 5, 2026, at 15:01, shaobo zhang <zshaoo224@gmail.com> wrote:
>
> The option_value grammar rule in src/pl/plpgsql/src/pl_gram.y was
> missing a terminating semicolon, which is inconsistent with the style
> used by other rules in the file. While Bison does not require
> semicolons to terminate grammar rules, adding one here improves
> consistency  and readability.
> <v1-0001-Fix-missing-semicolon-in-pl_gram.y-for-option_val.patch>

I would not call this a “fix” as it doesn’t fix anything not working today. It is actually a grammar-style cleanup.
Sincethe code being changed is 12 years old, I think this patch is a candidate for v20. 

Would you please add it to the CommitFest so that it can be noticed after v20 opens?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Ayush Tiwari
Date:
Subject: Re: Remove the refint contrib module (for v20)
Next
From: shveta malik
Date:
Subject: Re: DOCS - Add missing EXCEPT parameter description to ALTER PUBLICATION