Re: Remove inconsistent quotes from date_part error - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove inconsistent quotes from date_part error
Date
Msg-id 3546614.1641223235@sss.pgh.pa.us
Whole thread Raw
In response to Remove inconsistent quotes from date_part error  (Nikhil Benesch <nikhil.benesch@gmail.com>)
Responses Re: Remove inconsistent quotes from date_part error
List pgsql-hackers
Nikhil Benesch <nikhil.benesch@gmail.com> writes:
> -                         errmsg("\"time with time zone\" units \"%s\" not recognized",
> +                         errmsg("time with time zone units \"%s\" not recognized",
> [ etc ]

BTW, if you want to get rid of the quotes, I think that something
else has to be done to set off the type name from the rest.  In
this instance someone might think that we're complaining about a
"time zone unit", whatever that is.  I suggest swapping it around to

    units \"%s\" not recognized for type %s

Also, personally, I'd write unit not units, but that's
more debatable.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nikhil Benesch
Date:
Subject: Re: Remove inconsistent quotes from date_part error
Next
From: Nikhil Benesch
Date:
Subject: Re: Remove inconsistent quotes from date_part error