Re: backup manifests - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: backup manifests
Date
Msg-id 353d360a-0286-fda0-2de0-7f888a8ee323@oss.nttdata.com
Whole thread Raw
In response to Re: backup manifests  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

On 2020/04/23 1:28, Robert Haas wrote:
> On Wed, Apr 22, 2020 at 12:21 PM Fujii Masao
> <masao.fujii@oss.nttdata.com> wrote:
>> I found three minor issues in pg_verifybackup.
>>
>> +               {"print-parse-wal", no_argument, NULL, 'p'},
>>
>> This is unused option, so this line should be removed.
>>
>> +       printf(_("  -m, --manifest=PATH         use specified path for manifest\n"));
>>
>> Typo: --manifest should be --manifest-path
>>
>> pg_verifybackup accepts --quiet option, but its usage() doesn't
>> print any message for --quiet option.
>>
>> Attached is the patch that fixes those issues.
> 
> Thanks; LGTM.

Thanks for the review! Pushed.

Regards,  

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: [PATCH] Fix buffer not null terminated on (ecpg lib)
Next
From: Fujii Masao
Date:
Subject: Re: Remove non-fast promotion Re: Should we remove a fallbackpromotion? take 2