Re: [RFC] building postgres with meson -v - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [RFC] building postgres with meson -v
Date
Msg-id 3538f4c4-1886-64f2-dcff-aaad8267fb82@enterprisedb.com
Whole thread Raw
In response to Re: [RFC] building postgres with meson -v  (Andres Freund <andres@anarazel.de>)
Responses Re: [RFC] building postgres with meson -v
List pgsql-hackers
On 01.11.21 00:24, Andres Freund wrote:
> - remaining hardcoded configure tests (e.g. ACCEPT_TYPE_ARG*)

I think we can get rid of that one.

That test originally catered to some strange edge cases where the third 
argument was size_t that was not the same size as int.  That is long 
gone, if it ever really existed.  All systems currently of interest use 
either socklen_t or int, and socklen_t is always int.  (A few build farm 
animals report size_t, but they are all 32-bit.)

I think we can change the code to use socklen_t and add a simple check 
to typedef socklen_t as int if not available.  See attached patch.

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Allow escape in application_name
Next
From: Andres Freund
Date:
Subject: Re: [RFC] building postgres with meson -v