Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6 - Mailing list pgsql-hackers

From Thomas G. Lockhart
Subject Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6
Date
Msg-id 350DF909.6935B125@alumni.caltech.edu
Whole thread Raw
In response to Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6  (dg@illustra.com (David Gould))
Responses Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6  (dg@illustra.com (David Gould))
List pgsql-hackers
David Gould wrote:
>
> > > > > Can you submit an appropriate patch that can be included in the
> > > > > mega-patch to be created on Sunday?
> >
> > > > are hard to de-couple.  Now, I did not know we supported NetBSD on
> > > > VAX. Does it work, anyone?  Can I remove it?
> > >
> > > NetBSD on VAX in on our supported list, and was verified for v6.3 by Tom
> > > Helbekkmo.
> > >
> > > > This is going to be pretty tough to test on every platform we support,
> > > > so if it is done now, it will have to be done carefully.
> > >
> > > Is this behavior in v6.2.x? In any case, if it is anything but minimally
> > > trivial, it should be given a test on every supported platform, since it
> > > hits the heart of the platform-specific code, doesn't it? Seems like it
> > > should be put into the CVS tree and shaken out until the next release...
> >
> > Yea, that is what I was hinting at.
> >
> > --
> > Bruce Momjian                          |  830 Blythe Avenue
> > maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
>
> I tend to agree but am willing to compromise.
>
> Can we do only the easy platforms at this time
> If this will work, I am willing to hack this together tomorrow.
> What is the time frame for accepting a patch like this?

What do you think it would take to exercise the patch heavily enough on
any of the affected platforms to ensure that it behaves no worse than
the current code? Is a test case easy to set up and run? If so, you can
probably get ~5 platforms tested in the next few days, and reduce the
risk of including this in the mega-patch.

Alternatively, we could do this the day _after_ the mega-patch, so that
the two are decoupled, and have a nice "slock patch" a few days later.

At the moment, there aren't any large backend patches waiting to go (I
think Vadim is still sleeping to recover from v6.3 :)

                        - Tom

pgsql-hackers by date:

Previous
From: "Thomas G. Lockhart"
Date:
Subject: Re: [HACKERS] Re: [QUESTIONS] UPDATE statement ORACLE 6 compatible
Next
From: The Hermit Hacker
Date:
Subject: Re: [HACKERS] Re: [PATCHES] patches for 6.2.1p6