Re: Add new option 'all' to pg_stat_reset_shared() - Mailing list pgsql-hackers

From torikoshia
Subject Re: Add new option 'all' to pg_stat_reset_shared()
Date
Msg-id 350550211cf7d235cd92e5c7969e8f68@oss.nttdata.com
Whole thread Raw
In response to Re: Add new option 'all' to pg_stat_reset_shared()  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Add new option 'all' to pg_stat_reset_shared()
List pgsql-hackers
On 2023-11-15 09:47, Michael Paquier wrote:
> On Tue, Nov 14, 2023 at 10:02:32PM +0900, torikoshia wrote:
>> Attached patch.
> 
> You have forgotten to update the errhint at the end of
> pg_stat_reset_shared(), where "slru" needs to be listed :)

Oops, attached v2 patch.

>> BTW currently the documentation explains all the arguments of
>> pg_stat_reset_shared() in one line and I feel it's a bit hard to read.
>> Attached patch uses <itemizedlist>.
> 
> Yes, this one is a good idea because each target works on a different
> system view so it becomes easier to understand what a target affects,
> so I've applied this bit, without the slru addition.

Thanks!

> --
> Michael

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: A recent message added to pg_upgade
Next
From: Andres Freund
Date:
Subject: Re: typo in fallback implementation for pg_atomic_test_set_flag()