Re: Remove MSVC scripts from the tree - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Remove MSVC scripts from the tree
Date
Msg-id 34d6a8d6-bfcd-1123-fa8e-8fe7456c3e62@dunslane.net
Whole thread Raw
In response to Re: Remove MSVC scripts from the tree  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Remove MSVC scripts from the tree
List pgsql-hackers
On 2023-12-06 We 12:24, Peter Eisentraut wrote:
> On 06.12.23 17:27, Andrew Dunstan wrote:
>> But the VS2019 compiler implements enough of C99 to pass our meson 
>> test, unlike VS2017. Maybe the test is too strict. After all, we know 
>> we can in fact build with the earlier versions.
>
> I just realized that the C99 test is actually our own, not provided by 
> meson.  (See "c99_test" in meson.build.)
>
> Can you try disabling a few bits of that to see what makes it pass for 
> you?  I suspect it's the structfunc() call.


Yes, if I comment out the call to structfunc() the test passes on VS2017 
(compiler version 19.15.26726)


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: gai_strerror() is not thread-safe on Windows
Next
From: Andrew Dunstan
Date:
Subject: Re: Emitting JSON to file using COPY TO