Re: Ignoring white space in regression tests really a good idea? - Mailing list pgsql-hackers

From Alex Hunsaker
Subject Re: Ignoring white space in regression tests really a good idea?
Date
Msg-id 34d269d40911211605p7deaad1ax474e4529bfea6e6d@mail.gmail.com
Whole thread Raw
In response to Re: Ignoring white space in regression tests really a good idea?  ("David E. Wheeler" <david@kineticode.com>)
List pgsql-hackers
On Sat, Nov 21, 2009 at 16:07, David E. Wheeler <david@kineticode.com> wrote:
> On Nov 22, 2009, at 7:49 AM, Tom Lane wrote:
>
>> I'm thinking maybe we should remove -w.  Comments?
>
> Have you tried it on the existing tests to see what happens?

For me there I get:
*the breaking in create_cast
*various things in foreign_key due to the tests not having spaces
after commas i.e:
! DETAIL:  Key (ftest1,ftest2)=(2,2) is not present in table "pktable".
! DETAIL:  Key (ftest1, ftest2)=(100, 2) is not present in table "pktable".
* exta space after a "
! CONTEXT:  SQL statement "SELECT  1/ $1 "
! CONTEXT:  SQL statement "SELECT 1/$1"

All those things are easily fixable so it seems worth it to me +1


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: UTF8 with BOM support in psql
Next
From: Tom Lane
Date:
Subject: Re: Unicode UTF-8 table formatting for psql text output