Re: [HACKERS] inlining - Mailing list pgsql-hackers

From Vadim B. Mikheev
Subject Re: [HACKERS] inlining
Date
Msg-id 34D179F7.7B83D609@sable.krasnoyarsk.su
Whole thread Raw
In response to inlining  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
Sorry - this is with valid charset...

Vadim B. Mikheev wrote:
>
> Bruce Momjian wrote:
> >
> > Let me add, I am not inlining all the functions, but only the top part
> > of them that deals with cachoffsets and nulls.  These are the easy ones,
> > and the ones that get used most often.
>
> fastgetattr() is called from a HUNDREDS places - I'm not sure that
> this is good idea.
>
> I suggest to inline _entire_ body of this func in the
> execQual.c:ExecEvalVar() - Executor uses _only_ ExecEvalVar() to get
> data from tuples.
>
> (We could #define FASTGETATTR macro and re-write fastgetattr() as just
> this macro "call".)
>
> I don't know should we follow the same way for fastgetiattr() or not...
>
> Vadim

pgsql-hackers by date:

Previous
From: "Vadim B. Mikheev"
Date:
Subject: Re: [HACKERS] inlining
Next
From: "Vadim B. Mikheev"
Date:
Subject: Re: [HACKERS] Current open 6.3 issues (fwd)