Re: improving speed of make check-world - Mailing list pgsql-hackers

From Tom Lane
Subject Re: improving speed of make check-world
Date
Msg-id 34996.1430280762@sss.pgh.pa.us
Whole thread Raw
In response to Re: improving speed of make check-world  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On Tue, Apr 28, 2015 at 1:46 AM, Jeff Janes <jeff.janes@gmail.com> wrote:
>> This change fixed the problem for me.
>> It also made this age-old compiler warning go away:
>> 
>> In file included from gram.y:14515:
>> scan.c: In function 'yy_try_NUL_trans':
>> scan.c:10307: warning: unused variable 'yyg'
>> 
>> I guess by redirecting it into the log file you indicated, but is that a
>> good idea to redirect stderr?

> I am sure that Peter did that on purpose, both approaches having
> advantages and disadvantages. Personally I don't mind looking at the
> install log file in tmp_install to see the state of the installation,
> but it is true that this change is a bit disturbing regarding the fact
> that everything was directly outputted to stderr and stdout for many
> years.

Hm.  I don't really like the idea that "make all" behaves differently
if invoked by "make check" than if invoked directly.  Hiding warnings
from you is not very good, and hiding errors would be even more annoying.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: FIX : teach expression walker about RestrictInfo
Next
From: Michael Paquier
Date:
Subject: Re: [COMMITTERS] pgsql: Add transforms feature