Hi, All!
There is ongoing tendency in PostgreSQL to replace boolean reloptions that has
"on" and "off" state, with other option types that has "on", "off" and "use
defaults" states.
Some of these options are implemented as enum options. They are
"vacuum_index_cleanup" and gist's "buffering"
and one recently converted option "vacuum_truncate" that uses extra
"vacuum_truncate_set" flag to indicate it's unset state.
This patch introduce trenary reloptions type, that replaces both
implementation with separate data-type that behaves in the same way as bool
type does, but has one extra state that indicate that option have not been set
to "on" or "off" state.
This third state, I call it "unset" state, can either be only reached by not
setting "true" or "false" value to an option, as it is done in vacuum_truncate
option. Or option designer can assign this third state a custom name, so user
can explicitly set option to the "third" slate. As it is done in
`vacuum_index_cleanup` and gist's `buffering` option, using "auto" keyword.
This patch changes implementation of `vacuum_truncate`, `vacuum_index_cleanup`
and gist's `buffering` to trinary options. This make code more neat and
consistent. I'd suggest to commit it to the master branch.
Possible flaws and drawbacks:
1. I've added trenary enum type to c.h. It might be a bit too global, but I
did not find any better place for it, since it is needed globally and it is
kind of similar to boolean. If you know better place, please speak.
2. `vacuum_index_cleanup` and gist's `buffering` will now accepts all possible
"true" and "false" aliases as in boolean type, the way they did not do it
before. Like "1" or "FAL". I see no great harm in it, but it is still
behaviour change.
3. Error messages for `vacuum_index_cleanup` and gist's `buffering` are now
less informative. It is not right, but I do not see right now a way to improve
that. May be it is a price to pay for code consistency. If you have any idea
how to fix it, please speak.
As for the rest, other behavior should not be changed.
I've added as many tests as I can. local_reloption support is also
implemented.
I've split patch into four part so it can be read and reviewed step by step:
1. Tests that ensures old behaviour
2. Trenary option for `vacuum_truncate` reloption
3. Add "unset_alias" feature to implement "auto" alias for
`vacuum_index_cleanup` and gist's `buffering`
4. More tests
But I guess they should be commit as a single commit.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
