Re: pgindent vs. git whitespace check - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent vs. git whitespace check
Date
Msg-id 346043.1677127729@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent vs. git whitespace check  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: pgindent vs. git whitespace check
Re: pgindent vs. git whitespace check
List pgsql-hackers
John Naylor <john.naylor@enterprisedb.com> writes:
> On Thu, Feb 23, 2023 at 5:03 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> I suspect not allowing // is at least a minor annoyance to any new
>> developer we acquire under the age of about 40.

> pgindent changes those to our style, so it's not much of an annoyance if
> one prefers to type it that way during development.

Right, it's not like we reject patches for that (or at least, we shouldn't
reject patches for any formatting issues that pgindent can fix).

For my own taste, I really don't have any objection to // in isolation --
the problem with it is just that we've got megabytes of code in the other
style.  I fear it'd look really ugly to have an intermixture of // and /*
comment styles.  Mass conversion of /* to // style would answer that,
but would also create an impossible back-patching problem.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Allow logical replication to copy tables in binary format
Next
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pretty-printed XML output option