Re: Quick search for menu items & help articles - Mailing list pgadmin-hackers
Hi Akshay,
Thanks for your quick review ! Made changes as per your comments & attached patch with this email.
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Friday, 15 January 2021 at 12:14 PM
To: Pramod Ahire <pramod.ahire@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Subject: Re: Quick search for menu items & help articles
Hi Pramod
Following are the review comments:
- linter issue "Undefined variable $black"
- In Desktop mode remove the separator beside the search icon.
On Thu, Jan 14, 2021 at 10:18 PM Pramod Ahire <pramod.ahire@enterprisedb.com> wrote:
Hi Team,
Please find the attached designs & patch that contains complete functionality except below to do for quick search.
To Do:
- Unit test cases are not that sufficient to cover complete code, but will be working in background to cover up those one
- In pgadmin, for disabled menu items we need to add info that will describe why menu has disabled & how it will be enabled. Either another way to enable all of them & show respective reason in popup that menu is disabled for.
Please do let me know if I missed anything or suggestion of yours.
Thanks !
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
Mobile: +91 976-788-8246
Attachment
pgadmin-hackers by date: