Request a Demo
Home   >   mailing lists

Re: [PATCH] The heap_getsysattr function deletes unused parameters - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] The heap_getsysattr function deletes unused parameters
Date
Msg-id 3441872.1784130820@sss.pgh.pa.us
Whole thread
In response to [PATCH] The heap_getsysattr function deletes unused parameters  (lei yang <yanglei.ovo@gmail.com>)
Responses Re: [PATCH] The heap_getsysattr function deletes unused parameters
Re: [PATCH] The heap_getsysattr function deletes unused parameters
List pgsql-hackers
Tree view 
lei yang <yanglei.ovo@gmail.com> writes:
> The tupleDesc parameter in the heap_getsysattr function is not used,
> and the TupleDesc structure does not contain system attributes.
> Maybe we can delete the parameter tupleDesc.

I do not think this is a great idea.  We don't use the tupdesc today
perhaps, but it's plausible that it'd be needed in the future.
Different table AMs might have different sets of system columns.

Unless you can show a measurable performance gain from this change,
we should leave it alone.

            regards, tom lane

pgsql-hackers by date:

Previous
From: lei yang
Date:
Subject: [PATCH] The heap_getsysattr function deletes unused parameters
Next
From: Álvaro Herrera
Date:
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and -DEXEC_BACKEND at startup