Re: can we mark upper/lower/textlike functions leakproof? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: can we mark upper/lower/textlike functions leakproof?
Date
Msg-id 3440717.1722461283@sss.pgh.pa.us
Whole thread Raw
In response to Re: can we mark upper/lower/textlike functions leakproof?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> I'm not sure what the right thing to do here is, but I think that it's
> wrong to imagine that being unwilling to endorse probably-leakproof
> things as leakproof -- or unwilling to put in the work to MAKE them
> leakproof if they currently aren't -- has no security costs.

Well, we *have* been a little bit spongy about that --- notably,
that texteq and friends are marked leakproof.  But IMV, marking
upper/lower as leakproof is substantially riskier and offers
substantially less benefit than those did.

In general, I'm worried about a slippery slope here.  If we
start marking things as leakproof because we cannot prove
they leak, rather than because we can prove they don't,
we are eventually going to find ourselves in a very bad place.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Changing default -march landscape
Next
From: Nathan Bossart
Date:
Subject: Re: Popcount optimization using AVX512