Re: PATCH: Spinlock Documentation - Mailing list pgsql-hackers

<div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida
Grande,sans-serif;font-size:12px"><div dir="ltr" id="yui_3_16_0_1_1428270899481_6893">Hello,</div><div dir="ltr"
id="yui_3_16_0_1_1428270899481_6892"><br/></div><div dir="ltr" id="yui_3_16_0_1_1428270899481_6891">Thank you very much
foryour feedback! I will work on the changes as soon as I can. </div><div dir="ltr"
id="yui_3_16_0_1_1428270899481_6890"><br/></div><div dir="ltr"
id="yui_3_16_0_1_1428270899481_6889">Respectfully,</div><divdir="ltr" id="yui_3_16_0_1_1428270899481_6889"><br
/></div><divdir="ltr" id="yui_3_16_0_1_1428270899481_6889">Artem Luzyanin</div><br /><div class="qtdSeparateBR"><br
/><br/></div><div class="yahoo_quoted" style="display: block;"><div style="font-family: HelveticaNeue, Helvetica Neue,
Helvetica,Arial, Lucida Grande, sans-serif; font-size: 12px;"><div style="font-family: HelveticaNeue, Helvetica Neue,
Helvetica,Arial, Lucida Grande, sans-serif; font-size: 16px;"><div dir="ltr"><font face="Arial" size="2"> On Sunday,
April5, 2015 5:45 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:<br /></font></div><br /><br /><div
class="y_msg_container">DavidFetter <<a href="mailto:david@fetter.org" shape="rect"
ymailto="mailto:david@fetter.org">david@fetter.org</a>>writes:<div class="yqt5487667748" id="yqtfd17392"><br
clear="none"/>> One issue with this patch is that it is not localized.  If someone<br clear="none" />> goes and
changesthe S_LOCK implementation for one of the platforms<br clear="none" />> below, or adds a new platform, etc.,
withoutchanging this comment<br clear="none" />> too, this comment becomes confusingly obsolete.</div><br
clear="none"/><br clear="none" />Indeed.  Moreover, this header comment is supposed to be an overview and<br
clear="none"/>specification of the macros that need to be provided.  I think it's an<br clear="none" />actively bad
ideato clutter it with platform-by-platform details; that<br clear="none" />will create a "can't see the forest for the
trees"problem.<br clear="none" /><br clear="none" />If we need more info here, I think a comment block before each
section<brclear="none" />of the file would make more sense.  But the patch as provided seems<br clear="none" />like it
wouldjust be redundant if it were refactored in that form.<br clear="none" /><br clear="none" />What would possibly be
usefulthat's not there now is a paragraph or<br clear="none" />two describing the overall layout of the file (eg "gcc
thennon gcc",<br clear="none" />or whatever can be said at more or less that level of detail).  But<br clear="none"
/>pleasedon't stick that into the middle of the specification part.<br clear="none" /><br clear="none" />           
regards,tom lane<div class="yqt5487667748" id="yqtfd95033"><br clear="none" /></div><br /><br
/></div></div></div></div></div>