>>> So, it seems there is no user-visible change, except it is faster. Does
>>> it enable new workloads? A 3x speedup probably does. Should this be a
>>> pg_trgm item, with a description mentioning GIN in general, or should it
>>> be a GIN item, perhaps mentioning pg_trgm? Do you have any suggested
>>> text and list of commits?
>>
>> Not all patches from the initial mail have been committed yet. Hence,
>> currently the speed up is less. However, once they got all committed
>> they would indeed open up new "use cases". For example, I know users
>> that don't add GIN indexes to very large tables because creating them
>> takes too long.
>
> Yes, GIN index creation has always been considered slow, so it is good
> it is being worked on. I wonder if we should just wait for it all to be
> committed before adding it to the release notes, unless you want to
> measure the improvement we have in PG 19.
I've measured with the same benchmark I used in the original thread [1].
With latest master the results are as follows:
Dataset | REL_18_3 | master | Speedup
---------|------------|------------|--------
movies | 10,561 ms | 9,124 ms | 1.17x
lineitem | 263,523 ms | 234,605 ms | 1.12x
That's because three patches from the patchset haven't been committed
yet. Two of the three patches are the most impactful from the patchset.
[1]
https://www.postgresql.org/message-id/flat/5d366878-2007-4d31-861e-19294b7a583b%40gmail.com
--
David Geier
