Re: Add trailing commas to enum definitions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Add trailing commas to enum definitions
Date
Msg-id 33afb6db-a3a6-453d-a0c3-c8c9955be4fc@eisentraut.org
Whole thread Raw
In response to Re: Add trailing commas to enum definitions  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On 23.10.23 22:34, Nathan Bossart wrote:
> On Mon, Oct 23, 2023 at 05:55:32PM +0800, Junwang Zhao wrote:
>> On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>>> Since C99, there can be a trailing comma after the last value in an enum
>>
>> C99 allows us to do this doesn't mean we must do this, this is not
>> inconsistent IMHO, and this will pollute the git log messages, people
>> may *git blame* the file and see the reason for the introduction of the
>> line.
> 
> I suspect that your concerns about git-blame could be resolved by adding
> this commit to .git-blame-ignore-revs.  From a long-term perspective, I
> think standardizing on the trailing comma style will actually improve
> git-blame because patches won't need to add a comma to the previous line
> when adding a value.

Committed that way.




pgsql-hackers by date:

Previous
From: "Fujii.Yuki@df.MitsubishiElectric.co.jp"
Date:
Subject: RE: Partial aggregates pushdown
Next
From: Nikita Malakhov
Date:
Subject: Re: RFC: Pluggable TOAST