Re: pgindent vs variable declaration across multiple lines - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent vs variable declaration across multiple lines
Date
Msg-id 339921.1674180434@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent vs variable declaration across multiple lines  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2023-01-19 20:43:44 -0500, Tom Lane wrote:
>> What reindent-all-branches pain?  We haven't done an all-branches
>> reindent in the past, even for pgindent fixes that touched far more
>> code than this would (assuming that the proposed fix doesn't have
>> other side-effects).

> Oh. I thought we had re-indented the other branches when we modified
> pg_bsd_intent substantially in the past, to reduce backpatching pain. But I
> guess we just discussed that option, but didn't end up pursuing it.

Yeah, we did discuss it, but never did it --- I think the convincing
argument not to was that major reformatting would be very painful
for people maintaining forks, and we shouldn't put them through that
to track minor releases.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgindent vs variable declaration across multiple lines
Next
From: Peter Smith
Date:
Subject: Re: Logical replication timeout problem