Re: pg_dump --split patch - Mailing list pgsql-hackers

From Joel Jacobson
Subject Re: pg_dump --split patch
Date
Msg-id 3393745585032791441@iso-8859-1msgid
Whole thread Raw
In response to Re: pg_dump --split patch  (Gurjeet Singh <singh.gurjeet@gmail.com>)
List pgsql-hackers


Sent from my iPhone

On 28 dec 2010, at 21:45, Gurjeet Singh <singh.gurjeet@gmail.com> wrote:

The problem I see with suffixing a sequence id to the objects with name collision is that one day the dump may name myfunc(int) as myfunc.sql and after an overloaded version is created, say myfunc(char, int), then the same myfunc(int) may be dumped in myfunc-2.sql, which again is non-deterministic.

I agree, good point!
Perhaps abbreviations are to prefer, e.g., myfunc_i, myfunc_i_c, etc to reduce the need of truncating filenames.



Also, it is a project policy that we do not introduce new features in back branches, so spending time on an 8.4.6 patch may not be the best use of your time.

My company is using 8.4 and needs this feature, so I'll have to patch it anyway :)


Regards,
--
gurjeet.singh
@ EnterpriseDB - The Enterprise Postgres Company
http://www.EnterpriseDB.com

singh.gurjeet@{ gmail | yahoo }.com
Twitter/Skype: singh_gurjeet

Mail sent from my BlackLaptop device

pgsql-hackers by date:

Previous
From: Karl Lehenbauer
Date:
Subject: Re: Revised patches to add table function support to PL/Tcl (TODO item)
Next
From: Robert Haas
Date:
Subject: Re: and it's not a bunny rabbit, either