Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[] - Mailing list pgsql-hackers

From Joel Jacobson
Subject Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]
Date
Msg-id 338b32ec-b0ad-46b1-864e-4c470aad5624@www.fastmail.com
Whole thread Raw
In response to Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view
On Thu, Sep 2, 2021, at 00:03, Daniel Gustafsson wrote:
> I can see value in a function like this one, and the API is AFAICT fairly
> aligned with what I as a user would expect it to be given what we already have.

Good to hear and thanks for looking at this patch.

I've fixed the problem due to the recent change in setup_regexp_matches(),
which added a new int parameter "start_search".
I pass 0 as start_search, which I think should give the same behaviour as before.

I also changed the assigned oid values in pg_proc.dat for the two new regexp_positions() catalog functions.

$ make check

=======================
All 209 tests passed.
=======================

/Joel




Attachment

pgsql-hackers by date:

Previous
From: "Private Information Retrieval(PIR)"
Date:
Subject: Private Information Retrieval (PIR) as a C/C++ Aggregate Extension
Next
From: vignesh C
Date:
Subject: Re: Added schema level support for publication.