Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API - Mailing list pgsql-bugs

From Antonin Houska
Subject Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API
Date
Msg-id 33766.1780471821@localhost
Whole thread
In response to Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API  (Srinath Reddy Sadipiralla <srinath2133@gmail.com>)
Responses Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API
Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API
List pgsql-bugs
Srinath Reddy Sadipiralla <srinath2133@gmail.com> wrote:

> Could we reject the pgrepack plugin at slot creation instead, in
> pg_create_logical_replication_slot() and the CREATE_REPLICATION_SLOT
> command, so misuse gets a clear "reserved for REPACK (CONCURRENTLY)"
> error up front, before any decoding? REPACK creates its slot directly via
> ReplicationSlotCreate(), so it's unaffected, and the begin-callback check
> with magic guard can stay as the internal safety net.
> Happy to be told this isn't worth special-casing :)

Another possible approach: restrict the use of the plugin to the REPACK
decoding worker.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


Attachment

pgsql-bugs by date:

Previous
From: Srinath Reddy Sadipiralla
Date:
Subject: Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API
Next
From: Srinath Reddy Sadipiralla
Date:
Subject: Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API