Re: pg_indent instructions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_indent instructions
Date
Msg-id 336667.1624908567@sss.pgh.pa.us
Whole thread Raw
In response to pg_indent instructions  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> The README for pg_indent says:

>     ./configure     # "make" will not work in an unconfigured tree
>     cd src/include/catalog
>     make reformat-dat-files
>     cd ../../..

> This looks like a case of using a sledgehammer to crack a nut.

> I did this, which amounts to the same thing and is faster:

>     cd src/include/catalog
>     perl ./reformat_dat_file.pl --output . ./pg_*.dat
>     cd ../../..

True, that saves having to do a configure run, but it also embeds
some assumptions that personally I could do without --- mainly
about which perl you want to use.  In any case, configure is
pretty quick as long as you've got it set up to use a cache file.

One thing we should do, perhaps, is remove the "cd" steps in
favor of recommending

make -C src/include/catalog reformat-dat-files

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pg_indent instructions
Next
From: Elijah Stone
Date:
Subject: Re: Composite types as parameters