Re: pgsql: Remove IS_AF_UNIX macro - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove IS_AF_UNIX macro
Date
Msg-id 3323700.1645028015@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Remove IS_AF_UNIX macro  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-committers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 15.02.22 16:41, Tom Lane wrote:
>> I hadn't looked closely at this patch, but are you referring to
>> this bit in ip.h?

> In src/backend/utils/adt/pgstatfuncs.c there is a use of AF_UNIX that 
> has been there unprotected by any #ifdef since about 2008.

Oh, I see it :-(.  Poor coding, but it evidently no longer matters.

> Maybe/probably.  But there is a difference between platforms having the 
> AF_UNIX symbol (which is required by POSIX unconditionally) and 
> platforms actually having Unix sockets or not (which might require 
> different default configurations or run-time behavior), so the two 
> questions are not that closely connected.

Fair point.

            regards, tom lane



pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Remove IS_AF_UNIX macro
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix bogus log message when starting from a cleanly shut down sta