Re: segmentation fault when cassert enabled - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: segmentation fault when cassert enabled
Date
Msg-id 32a64f45-6c01-d2bf-d90a-49ff4bfedcfb@2ndquadrant.com
Whole thread Raw
In response to Re: segmentation fault when cassert enabled  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: segmentation fault when cassert enabled  (Jehan-Guillaume de Rorthais <jgdr@dalibo.com>)
List pgsql-hackers
On 2019-12-16 11:11, Amit Kapila wrote:
> I agree that this is a timing issue.  I also don't see a way to write
> a reproducible test for this.  However, I could reproduce it via
> debugger consistently by following the below steps.  I have updated a
> few comments and commit messages in the attached patch.
> 
> Peter E., Petr J or anyone else, do you have comments or objections on
> this patch?  If none, then I am planning to commit (and backpatch)
> this patch in a few days time.

The patch seems fine to me.  Writing a test seems hard.  Let's skip it.

The commit message has a duplicate "building"/"built" in the first sentence.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Collation versions on Windows (help wanted, apply within)
Next
From: Juan José Santamaría Flecha
Date:
Subject: Re: Collation versions on Windows (help wanted, apply within)