Re: Use \if/\endif to remove non-libxml2 expected output in regression tests - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
Date
Msg-id 32CC16E4-DA1F-46E1-815D-106A8075ADD1@yesql.se
Whole thread
In response to Use \if/\endif to remove non-libxml2 expected output in regression tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Use \if/\endif to remove non-libxml2 expected output in regression tests
List pgsql-hackers
> On 12 Jun 2026, at 09:49, Michael Paquier <michael@paquier.xyz> wrote:

> I'd like to backpatch that down to v14, to ease future maintenance.
> Any comments and/or objections?

Skipping tests when the underlying library/platform support is missing is in
line with how the TAP tests already do it.  We would lose coverage of invoking
XML functions without libxml support, which risk hiding bugs in the error-
handling (which is already the case with the TAP tests etc).  For libxml that
might be acceptable since the error paths are quite small (and by now
welltested) and the XML code isn't really moving all that much.

I think there needs to be a big comment explaining the skip_test clause though.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Use \if/\endif to remove non-libxml2 expected output in regression tests
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: [BUG] Take a long time to reach consistent after pg_rewind