Re: Unhappy about API changes in the no-fsm-for-small-rels patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Unhappy about API changes in the no-fsm-for-small-rels patch
Date
Msg-id 3286.1555439485@sss.pgh.pa.us
Whole thread Raw
In response to Unhappy about API changes in the no-fsm-for-small-rels patch  (Andres Freund <andres@anarazel.de>)
Responses Re: Unhappy about API changes in the no-fsm-for-small-rels patch
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> I'm kinda thinking that this is the wrong architecture.

The bits of that patch that I've looked at seemed like a mess
to me too.  AFAICT, it's trying to use a single global "map"
for all relations (strike 1) without any clear tracking of
which relation the map currently describes (strike 2).
This can only work at all if an inaccurate map is very fail-soft,
which I'm not convinced it is, and in any case it seems pretty
inefficient for workloads that insert into multiple tables.

I'd have expected any such map to be per-table and be stored in
the relcache.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: hyrax vs. RelationBuildPartitionDesc
Next
From: Peter Geoghegan
Date:
Subject: Re: Improve search for missing parent downlinks in amcheck