Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date
Msg-id 3274.1292084616@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Sat, Dec 11, 2010 at 17:13, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Ah, I have a theory: <fcntl.h>.

> Nope, not there. I can't find S_IWGRP in any of the files.

Well, I notice that copydir.c compiled before, and still compiles after,
despite this change:

-   if (mkdir(todir, S_IRUSR | S_IWUSR | S_IXUSR) != 0)
+   if (mkdir(todir, S_IRWXU) != 0)

I think the reason it's not failing is that it includes <fcntl.h>.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Next
From: Magnus Hagander
Date:
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags