Re: [PATCH] Allow complex data for GUC extra. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Allow complex data for GUC extra.
Date
Msg-id 3253965.1767059085@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Allow complex data for GUC extra.  (Bryan Green <dbryan.green@gmail.com>)
Responses Re: [PATCH] Allow complex data for GUC extra.
List pgsql-hackers
Bryan Green <dbryan.green@gmail.com> writes:
> One notable behavioral change: check hooks using GUC_EXTRA_IS_CONTEXT
> now use palloc() instead of guc_malloc(). The old approach with
> guc_malloc() allowed check hooks to return false on OOM, letting the
> caller handle it at the appropriate error level. With palloc() an OOM
> throws an immediate ERROR. This seemed like an acceptable tradeoff

Why?  It seems both inconsistent and unsafe.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE
Next
From: "zengman"
Date:
Subject: Re: POC: make mxidoff 64 bits