Re: Redefining inet_net_ntop - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Redefining inet_net_ntop
Date
Msg-id 32437.1516980468@sss.pgh.pa.us
Whole thread Raw
In response to Re: Redefining inet_net_ntop  (Emre Hasegeli <emre@hasegeli.com>)
Responses Re: Redefining inet_net_ntop
List pgsql-hackers
Emre Hasegeli <emre@hasegeli.com> writes:
>> port.h declares inet_net_ntop and we always compile our own from
>> port/inet_net_ntop.c .

> There is another copy of it under backend/utils/adt/inet_cidr_ntop.c.
> The code looks different but does 90% the same thing.  Their naming
> and usage is confusing.

> I recently needed to format IP addresses as DNS PTR records in the
> database, and got annoyed by having no functions that outputs IPv6
> addresses in easily parseable format like
> 0000:0000:0000:0000:0000:0000:0000:0000.  I was going to send a patch
> to unify those C functions and add another SQL function to get
> addresses in such format.  Is this a good plan?  Where should those C
> functions be on the tree if they are not port of anything anymore?

Almost certainly, the thing to do is absorb updated code from bind,
not roll our own.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Updating timezone data to 2018c
Next
From: Vik Fearing
Date:
Subject: Re: \describe*