Re: [HACKERS] CREATE SUBSCRIPTION log noise - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] CREATE SUBSCRIPTION log noise
Date
Msg-id 3242bf64-0f11-2790-ec28-dacf9d21209e@2ndquadrant.com
Whole thread Raw
In response to [HACKERS] CREATE SUBSCRIPTION log noise  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: [HACKERS] CREATE SUBSCRIPTION log noise  (Euler Taveira <euler@timbira.com.br>)
List pgsql-hackers
On 6/20/17 22:54, Jeff Janes wrote:
> I think this should go away:
> 
>                 ereport(NOTICE,
>                       (errmsg("created replication slot \"%s\" on
> publisher",
>                               slotname)));
> 
> It doesn't appear to be contingent on anything other than the content of
> the command you just gave it.  I don't think we need a NOTICE saying
> that it did that thing I just told it to do--that should be implicit by
> the lack of an ERROR.

I'm appreciative of this complaint.  The point is that we are allocating
resources on a remote host that should not be forgotten.  I could go
either way.

Other opinions?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: [HACKERS] Fast promotion not used when doing a recovery_target PITR restore?
Next
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org