Re: [PROPOSAL] Client Log Output Filtering - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PROPOSAL] Client Log Output Filtering
Date
Msg-id 32424.1457621519@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PROPOSAL] Client Log Output Filtering  (David Steele <david@pgmasters.net>)
Responses Re: [PROPOSAL] Client Log Output Filtering
List pgsql-hackers
David Steele <david@pgmasters.net> writes:
> On 3/9/16 7:37 PM, Petr Jelinek wrote:
>> Looking at the code, this adds bool hide_from_client to edata which is
>> not initialized in errstart so that needs to be fixed.

> I figured this would take care of it:
> MemSet(edata, 0, sizeof(ErrorData));
> Since I want hide_from_client to default to false.  Am I missing something?

The patch is evidently modeled on errhidestmt and errhidectx, which are
making the same assumption for their fields.

I wonder whether, instead of continuing to proliferate random bool fields
in struct ErrorData, we oughta replace them all with an "int flags" field.
That's probably material for a separate patch though.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Floating point timestamps
Next
From: Alvaro Herrera
Date:
Subject: Re: Add generate_series(date,date) and generate_series(date,date,integer)