Re: Improve logging when using Huge Pages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Improve logging when using Huge Pages
Date
Msg-id 3239882.1667836576@sss.pgh.pa.us
Whole thread Raw
In response to Re: Improve logging when using Huge Pages  (Andres Freund <andres@anarazel.de>)
Responses Re: Improve logging when using Huge Pages
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2022-11-06 14:04:29 +0700, John Naylor wrote:
>> I think the best thing to do is change huge_pages='on' to log a WARNING and
>> fallback to regular pages if the mapping fails.

> I am strongly opposed to making 'on' fall back to not using huge pages. That's
> what 'try' is for.

Agreed --- changing "on" to be exactly like "try" isn't an improvement.
If you want "try" semantics, choose "try".

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Jonathan S. Katz"
Date:
Subject: 2022-11-10 release announcement draft
Next
From: Erikjan Rijkers
Date:
Subject: Re: 2022-11-10 release announcement draft