Re: [PATCH] pg_statio_all_tables: several rows per table due to invalid TOAST index - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] pg_statio_all_tables: several rows per table due to invalid TOAST index
Date
Msg-id 3235677.1648214938@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] pg_statio_all_tables: several rows per table due to invalid TOAST index  (Andrei Zubkov <zubkov@moonset.ru>)
List pgsql-hackers
Andrei Zubkov <zubkov@moonset.ru> writes:
> Thank you for your attention and for the problem resolution. However
> I'm worry a little about possible performance issues related to
> monitoring solutions performing regular sampling of statistic views to
> find out the most intensive objects in a database.

There's no actual evidence that the new formulation is meaningfully
worse for such cases.  Sure, it's probably *somewhat* less efficient,
but that could easily be swamped by pgstat or other costs.  I wouldn't
care to worry about this unless some evidence is presented that we've
created a big problem.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: pg_relation_size on partitioned table
Next
From: Tom Lane
Date:
Subject: Re: automatically generating node support functions