Re: copy_file_range is now a Linux kernel call - Mailing list pgsql-hackers

From Tom Lane
Subject Re: copy_file_range is now a Linux kernel call
Date
Msg-id 32230.1514952485@sss.pgh.pa.us
Whole thread Raw
In response to Re: copy_file_range is now a Linux kernel call  (Andres Freund <andres@anarazel.de>)
Responses Re: copy_file_range is now a Linux kernel call
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2018-01-02 22:44:04 -0500, Tom Lane wrote:
>> Looks like we'd better rename our function.  Anybody have an idea
>> more creative than "pg_copy_file_range"?

> I'd rather name it pg_rewind specific,

OK ...

> something like
> rwnd_copy_file_range or such.

Bleah --- "rwnd" is unpronounceable and not an abbreviation we're
currently using anywhere.  If we go that way, let's brave carpal tunnel
syndrome by calling it "rewind_copy_file_range".  But I'm not that
happy with any of these.

Filipe Rosset pointed out to me off-list that we're not the only
ones feeling the pain:

https://sourceforge.net/p/e2fsprogs/code/ci/01551bdba16ab16512a01affe02ade32c41ede8a

Maybe go with copy_file_chunk like e2fsprogs did?

            regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] GnuTLS support
Next
From: Amit Kapila
Date:
Subject: Re: Observations in Parallel Append