Re: incorrect xlog.c coverage report - Mailing list pgsql-hackers

From Tom Lane
Subject Re: incorrect xlog.c coverage report
Date
Msg-id 32188.1559323858@sss.pgh.pa.us
Whole thread Raw
In response to Re: incorrect xlog.c coverage report  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I forgot to mention that this patch produces a new warning:

> /pgsql/source/master/src/backend/tcop/postgres.c: In function 'quickdie':
> /pgsql/source/master/src/backend/tcop/postgres.c:2737:2: warning: implicit declaration of function '__gcov_flush';
didyou mean 'pq_flush'? [-Wimplicit-function-declaration] 
>   __gcov_flush();
>   ^~~~~~~~~~~~
>   pq_flush

> I couldn't find a way to squelch that.  gcc devs in their infinite
> wisdom don't provide a prototype for it, apparently.

Ugh.  So let's supply our own prototype, presumably it's just

extern void __gcov_flush(void);

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: incorrect xlog.c coverage report
Next
From: David Rowley
Date:
Subject: Re: Comment typo in tableam.h