Re: Something is wrong with wal_compression - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Something is wrong with wal_compression
Date
Msg-id 3218320.1674771285@sss.pgh.pa.us
Whole thread Raw
In response to Re: Something is wrong with wal_compression  (Andrey Borodin <amborodin86@gmail.com>)
Responses Re: Something is wrong with wal_compression
List pgsql-hackers
Andrey Borodin <amborodin86@gmail.com> writes:
> On Thu, Jan 26, 2023 at 12:12 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> That test case is demonstrating fundamental
>> database corruption after a crash.

> Not exactly corruption. XID was not persisted and buffer data did not
> hit a disk. Database is in the correct state.

Really?  I don't see how this part is even a little bit okay:

[00:40:50.744](0.046s) not ok 3 - xid is aborted after crash
[00:40:50.745](0.001s) 
[00:40:50.745](0.000s) #   Failed test 'xid is aborted after crash'
#   at t/011_crash_recovery.pl line 57.
[00:40:50.746](0.001s) #          got: 'committed'
#     expected: 'aborted'

If any tuples made by that transaction had reached disk,
we'd have a problem.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: improving user.c error messages
Next
From: Tom Lane
Date:
Subject: Re: suppressing useless wakeups in logical/worker.c