Re: Crash issue in PG18.5 regression - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Crash issue in PG18.5 regression
Date
Msg-id 3217de2d-2c7b-4ef2-ac9a-3958d62c78c0@iki.fi
Whole thread
In response to Re: Crash issue in PG18.5 regression  (Álvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
On 11/08/2026 20:02, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2026-08-11 12:41:49 +0300, Heikki Linnakangas wrote:
>>> Like the attached.
> 
>> I wonder if we also ought to do something about the other uses of
>> pg_locale_t->info.lt in pg_locale_libc.c?  That's at least strncoll_libc(),
>> strnxfrm_libc().  I think all the in-core callers guard them, but the
>> protection seems mighty far away in some cases.
> 
> We don't have a lot of time to think about this, and AFAICS the
> security patch only added calls to pg_strupper and pg_strlower.
> So as long as those are protected I'm content to ship.

+1. It'd be good to look at those, but not right now.

I have pushed the fix.

- Heikki




Attachment

pgsql-hackers by date:

Previous
From: Jakub Wartak
Date:
Subject: Re: [Bug Report + Patch] File descriptor leak when io_method=io_uring
Next
From: Alexandre Felipe
Date:
Subject: Re: Restructured Shared Buffer Hash Table