Re: pgsql: Minor pg_dump improvements - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Minor pg_dump improvements
Date
Msg-id 32026.1391987717@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Minor pg_dump improvements  (Stephen Frost <sfrost@snowman.net>)
List pgsql-committers
Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> grep shows me a couple of other places where the result of ftello doesn't
>> seem to be getting checked for error.  Odd that Coverity didn't notice
>> those.

> At least two of those are in a #if 0 block... since 2001
> (pg_backup_tar.c:_tarGetHeader).  I'm thinking we may be better off
> removing that code rather than continuing to pull it along

Works for me.

> The last is inside a snprintf() which is just building a string to call
> exit_horribly() with- seems like that's safe enough?

Agreed.  Printing -1 seems like appropriate behavior there.

            regards, tom lane


pgsql-committers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: pgsql: Minor pg_dump improvements
Next
From: Stephen Frost
Date:
Subject: pgsql: Further pg_dump / ftello improvements