Re: Making Vars outer-join aware - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Making Vars outer-join aware
Date
Msg-id 3197069.1683202924@sss.pgh.pa.us
Whole thread Raw
In response to Re: Making Vars outer-join aware  ("Anton A. Melnikov" <aamelnikov@inbox.ru>)
Responses Re: Making Vars outer-join aware
List pgsql-hackers
"Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
> The thing is that for custom scan nodes as readme says:
> "INDEX_VAR is abused to signify references to columns of a custom scan tuple type"
> But INDEX_VAR has a negative value, so it can not be used in varnullingrels bitmapset.
> And therefore this improvement seems will not work with custom scan nodes and some
> extensions that use such nodes.

Under what circumstances would you be trying to inject INDEX_VAR
into a nullingrel set?  Only outer-join relids should ever appear there.
AFAICS the change you propose would serve only to mask bugs.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: evtcache: EventTriggerCache vs Event Trigger Cache
Next
From: Tom Lane
Date:
Subject: Re: PL/Python: Fix return in the middle of PG_TRY() block.