Re: Minor typo - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Minor typo
Date
Msg-id 31872.1543364319@sss.pgh.pa.us
Whole thread Raw
In response to Re: Minor typo  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Minor typo  (Michael Paquier <michael@paquier.xyz>)
Re: Minor typo  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 28 Nov 2018, at 00:43, Stephen Frost <sfrost@snowman.net> wrote:
>> Sending it here in case anyone feels that we should do more than just
>> correct the word..?  Perhaps for non-native English speakers seeing
>> "whose" used here is confusing?

> Being a non-native English speaker I think it’s fine and, in my own bias,
> commonly understood.

I agree that "which" is just wrong here, but "whose" seems a bit malaprop
as well, and it's not the only poor English in that sentence.  Maybe
rewrite the whole sentence to avoid the problem?

  * When wal_compression is enabled and a "hole" is removed from a full
  * page image, the page image is compressed using PGLZ compression.

(BTW, is this trying to say that we don't apply compression if the page
contains no hole?  If so, why not?)

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: [PATCH] Tiny CREATE STATISTICS tab-completion cleanup
Next
From: Michael Paquier
Date:
Subject: Re: Minor typo