Re: pg_archivecleanup bug - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_archivecleanup bug
Date
Msg-id 31842.1395150968@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_archivecleanup bug  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pg_archivecleanup bug  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Very good point.  I have modified the patch to add this block in all
> cases where it was missing.  I started to wonder about the comment and
> if the Mingw fix was released.  Based on some research, I see this as
> fixed in mingw-runtime-3.2, released 2003-10-10.  That's pretty old. 

Yeah.  I would vote for removing that code in all branches.  There is no
reason to suppose somebody is going to install 8.4.22 on a machine that
they haven't updated mingw on since 2003.  Or, if you prefer, just remove
it in HEAD --- but going around and *adding* more copies seems like
make-work.  The fact that we've not heard complaints about the omissions
is good evidence that nobody's using the buggy mingw versions anymore.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Make it easy to detach completely from shared memory.
Next
From: Simon Riggs
Date:
Subject: Re: [COMMITTERS] pgsql: Make it easy to detach completely from shared memory.