Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue() - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()
Date
Msg-id 31412.1529072727@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> On Fri, Jun 15, 2018 at 4:46 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Maybe I just lack caffeine, but I don't see anything especially
>> wrong with what you wrote?

> It doesn't contain something particular wrong, but it's just badly
> formatted.  As I can see, we're keeping lines in commit messages no
> longer than 80 characters when possible.  I've commit message with 158
> characters line for no reason.  It was just because I wrote this
> commit message with word wrapping enabled.

Ah, it wrapped in my mail app so I didn't notice.

FWIW, I actually try to keep commit log lines to 75 characters, because
that's what displays nicely in "git log".  Links such as Discussion:
tags tend to run over, but there's little to be done about that as long
as gmail insists on such ridiculously long message IDs :-(

            regards, tom lane


pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()
Next
From: Alexander Korotkov
Date:
Subject: Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()