Re: move hash_any to utils/hash/hashfn.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: move hash_any to utils/hash/hashfn.c
Date
Msg-id 31389.1548446737@sss.pgh.pa.us
Whole thread Raw
In response to Re: move hash_any to utils/hash/hashfn.c  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2019-01-25 16:35:18 -0300, Alvaro Herrera wrote:
>> Would anybody object too hard if I move hash_any() and friends to
>> src/backend/utils/hash/hashfn.c and the declarations to
>> src/include/utils/hashutils.h?

> I hate the current split quite a bit, albeit for somewhat different
> reasons. We make things like tag_hash, uint32_hash unnecessarily more
> expensive by adding an entirely useless external function call. And
> some of these can be fairly hot (e.g. for syscache).  So yea, let's
> move this stuff together.

+1

            regards, tom lane


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: move hash_any to utils/hash/hashfn.c
Next
From: Merlin Moncure
Date:
Subject: crosstab/repivot...any interest?