Re: The unused_oids script should have a reminder to use the 8000-8999 OID range - Mailing list pgsql-hackers

From Tom Lane
Subject Re: The unused_oids script should have a reminder to use the 8000-8999 OID range
Date
Msg-id 31311.1564784357@sss.pgh.pa.us
Whole thread Raw
In response to Re: The unused_oids script should have a reminder to use the8000-8999 OID range  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: The unused_oids script should have a reminder to use the8000-8999 OID range  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes:
> Attached is v3, which implements your suggestion, generating output
> like the above. I haven't written a line of Perl in my life prior to
> today, so basic code review would be helpful.

The "if ($oid > $prev_oid + 2)" test seems unnecessary.
It's certainly wrong to keep iterating beyond the first
oid that's > $suggestion.

Perhaps you meant to go back and try a different suggestion
if there's not at least 2 free OIDs?  But then there needs
to be an outer loop around both of these loops.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Floris Van Nee
Date:
Subject: Re: Optimize single tuple fetch from nbtree index
Next
From: Tomas Vondra
Date:
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions