Re: pg15b2: large objects lost on upgrade - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg15b2: large objects lost on upgrade
Date
Msg-id 3125878.1659558856@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg15b2: large objects lost on upgrade  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: pg15b2: large objects lost on upgrade
List pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes:
> It couldn't hurt to do that as well, in passing (at the same time as
> testing that newrelfrozenxid >= oldrelfrozenxid directly). But
> deliberately running VACUUM afterwards seems like a good idea. We
> really ought to expect VACUUM to catch cases where
> relfrozenxid/relminmxid is faulty, at least in cases where it can be
> proven wrong by noticing some kind of inconsistency.

That doesn't seem like it'd be all that thorough: we expect VACUUM
to skip pages whenever possible.  I'm also a bit concerned about
the expense, though admittedly this test is ridiculously expensive
already.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Unstable tests for recovery conflict handling
Next
From: Robert Haas
Date:
Subject: Re: pg15b2: large objects lost on upgrade