Re: [HACKERS] A note about debugging TAP failures - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] A note about debugging TAP failures
Date
Msg-id 30931.1492896349@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] A note about debugging TAP failures  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] A note about debugging TAP failures  (Andres Freund <andres@anarazel.de>)
Re: [HACKERS] A note about debugging TAP failures  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2017-04-22 16:22:59 -0400, Tom Lane wrote:
>> In the particular case I was interested in here, the test script thought
>> everything was successful :-(.  I'm working on fixing that little problem,
>> but I do not believe that the TAP scripts are so bulletproof that there
>> will never be a need to override their judgment.

> Agreed.  If paths are reproducible and cleaned up on next run it's also
> much less of an issue to just leave them around till the next run.
> Which we imo also should do for non-failing tmp_check directories.

Mm, not convinced.  I think that the delete-on-success behavior was
intentional, to limit the amount of disk space a buildfarm member would
consume during a run.  I don't mind that being the default, as long as
there's a way to override it manually.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] A note about debugging TAP failures
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] A note about debugging TAP failures