Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders
Date
Msg-id 30846.1578347016@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
Julien Rouhaud <rjuju123@gmail.com> writes:
> On Mon, Jan 6, 2020 at 7:57 PM Pierre Ducroquet <p.psql@pinaraf.info> wrote:
>> My deepest apologies for the patch being broken, I messed up when transferring
>> it between my computers after altering the comments. The verbatim one attached
>> to this email applies with no issue on current HEAD.
>> The patch regarding PostmasterIsAlive is completely pointless since v12 where
>> the function was rewritten, and was included only to help reproduce the issue
>> on older versions. Back-patching the walsender patch further than v12 would
>> imply back-patching all the machinery introduced for PostmasterIsAlive
>> (9f09529952) or another intrusive change there, a too big risk indeed.

> +1, backpatch to v12 looks sensible.

Pushed with some minor cosmetic fiddling.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: weird libpq GSSAPI comment
Next
From: Stephen Frost
Date:
Subject: Re: weird libpq GSSAPI comment